Skip to content

refactor(indexer): extract magic values into named constants - #1193

Merged
Xoulomon merged 1 commit into
Xoulomon:mainfrom
MJ-RWA:refactor/extract-indexer-magic-constants
Aug 30, 2026
Merged

refactor(indexer): extract magic values into named constants#1193
Xoulomon merged 1 commit into
Xoulomon:mainfrom
MJ-RWA:refactor/extract-indexer-magic-constants

Conversation

@MJ-RWA

@MJ-RWA MJ-RWA commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR improves code clarity and maintainability across the indexer by extracting configuration-like magic numbers and strings into descriptive named constants.

Changes

  • Audited the sync, pipeline, and queries modules for configuration-like inline literals
  • Added descriptive constants to indexer/src/constants.ts
  • Updated relevant call sites to use the shared named constants
  • Reused existing constants where applicable
  • Preserved all existing values and runtime behavior

Testing

  • Ran the relevant indexer unit tests
  • Verified the changes do not alter existing behavior

Notes

This is a cleanup-only refactor with no intended functional or behavioral changes.
Closes: #1164

@MJ-RWA
MJ-RWA requested a review from Xoulomon as a code owner August 30, 2026 07:35
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@MJ-RWA Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Xoulomon
Xoulomon merged commit 835350a into Xoulomon:main Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code Quality] Extract magic numbers/strings into named constants across indexer

2 participants